Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove @angular/http #27038

Closed
wants to merge 1 commit into from
Closed

feat: remove @angular/http #27038

wants to merge 1 commit into from

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Nov 10, 2018 •
edited

BREAKING CHANGE:

  • This removes @angular/http from the list of supported Angular core APIs. The new official API for HTTP in Angular is @angular/common/http

@CaerusKaru CaerusKaru force-pushed the adam/http branch 18 times, most recently from c7533da to fb7d915 Compare November 13, 2018 04:30
@IgorMinar IgorMinar added this to the v8-candidates milestone Nov 15, 2018
@ngbot ngbot bot removed this from the v8-candidates milestone Nov 15, 2018
@IgorMinar
Copy link
Contributor

I'd love for this to happen in v8! Would you be willing to work through the cleanup, writing up migration instructions for anyone still using the old http, and get this PR into a mergable state?

@IgorMinar IgorMinar added this to the v8-candidates milestone Nov 15, 2018
@ngbot ngbot bot removed this from the v8-candidates milestone Nov 15, 2018
@IgorMinar IgorMinar added this to the v8-candidates milestone Nov 16, 2018
@ngbot ngbot bot removed this from the v8-candidates milestone Nov 16, 2018
@IgorMinar IgorMinar added this to the v8-candidates milestone Nov 16, 2018
@ngbot ngbot bot removed this from the v8-candidates milestone Nov 16, 2018
@IgorMinar IgorMinar added this to the v8-candidates milestone Nov 16, 2018
@ngbot ngbot bot removed this from the v8-candidates milestone Nov 16, 2018
@kara
Copy link
Contributor

kara commented Apr 28, 2020

@CaerusKaru Rebase?

@CaerusKaru CaerusKaru force-pushed the adam/http branch 2 times, most recently from 9b1301a to cc812a8 Compare April 28, 2020 19:09
kara
kara approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 1, 2020
@kara kara assigned IgorMinar and unassigned CaerusKaru May 1, 2020
@kara kara added the target: major This PR is targeted for the next major release label May 1, 2020
IgorMinar
IgorMinar approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for being super patient!

The merging of this PR is still blocked on a config change CL in google3 that @matsko is landing right now.

Reviewed-for: global-approvers

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker state: blocked and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 4, 2020
@kara kara removed request for a team May 4, 2020 23:28
@kara
Copy link
Contributor

kara commented May 4, 2020

G3 change should be in, so this is unblocked

@matsko
Copy link
Contributor

matsko commented May 4, 2020

@kara @IgorMinar unfortunately the G3 change is causing files to be removed. We can't merge this yet.

@matsko
Copy link
Contributor

matsko commented May 5, 2020

This is now unblocked because G3 doesn't sync @angular/http anymore.

Here's the latest sync (of this PR) that proves it: https://critique-ng.corp.google.com/cl/309988926

@CaerusKaru @alxhub
feat: remove @angular/http
dd32648 
The legacy HTTP package was deprecated in v5 with the launch of
@angular/common/http. The legacy package hasn't been published
since v7, and will therefore not include a migration.
@alxhub alxhub closed this in 388dc93 May 6, 2020
@IgorMinar IgorMinar mentioned this pull request May 16, 2020
Closed
3 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@CaerusKaru @profanis
feat: remove @angular/http (angular#27038)
759aa70 
The legacy HTTP package was deprecated in v5 with the launch of
@angular/common/http. The legacy package hasn't been published
since v7, and will therefore not include a migration.

PR Close angular#27038
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort2: days risk: medium target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
v10-candidates
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@CaerusKaru @IgorMinar @alexeagle @ankeshdave @petebacondarwin @kara @matsko @googlebot